Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement generate-index-metadata command #6324

Closed

Conversation

synek317
Copy link

It solves the issue #4497

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks for the PR! Unfortunately now though there's a soft feature freeze in Cargo so it may be some time before the cargo team has bandwidth to review this

@synek317 synek317 changed the title Synek317 generate index metadata Implement generate-index-metadata command Nov 19, 2018
@Eh2406
Copy link
Contributor

Eh2406 commented Nov 22, 2018

As someone without much of the background context, I would like to see more documentation. What dose it do? How can it be used? How can it be configured?

If my guess about what this does, I'd love to see an extenuation that let us take a resolution bug report and tern it into a reproducible test case.

@bors
Copy link
Contributor

bors commented Nov 26, 2018

☔ The latest upstream changes (presumably #6347) made this pull request unmergeable. Please resolve the merge conflicts.

@synek317 synek317 force-pushed the synek317_generate_index_metadata branch from 95795ee to 2a5ad7c Compare December 19, 2018 11:39
@synek317 synek317 force-pushed the synek317_generate_index_metadata branch from 2a5ad7c to 440939e Compare December 19, 2018 21:32
@synek317
Copy link
Author

@alexcrichton was it freeze until rust 2018 release or is it freeze to the end of the year?
I've rebased my branch so it is mergeable again.

@Eh2406
Copy link
Contributor

Eh2406 commented Dec 21, 2018

cc @ehuss

@ehuss
Copy link
Contributor

ehuss commented Dec 23, 2018

At this time I think we'd like to experiment with index-related commands out of tree. I'm putting together a new subcommand which provides several options for managing an index, which I'll be posting soon. Do you have interest in running a registry? If so, feedback and testing would be helpful to figure out what features are needed.

@synek317
Copy link
Author

synek317 commented Dec 27, 2018

This is my subcommand to create registry in a git repository: https://github.com/synek317/cargo-git-registry

It is very much work in progress but with generate-index-metadata it worked well and I've successfully created registry. Maybe the last issue was copy-paste the code from crates.io to create registry directories (e.g. ca/rg/cargo), but this is really small.

With generate-index-metadata in master cargo branch I'm going to go back to this project. It would really help me at work.

@ehuss
Copy link
Contributor

ehuss commented Dec 29, 2018

@synek317 Nice! I'm trying to make it possible to implement this separately just using cargo metadata because linking against Cargo is a pain. I hit a bit of a roadblock due to some implementation issues, but I hope to have it resolved soon.

@dwijnand
Copy link
Member

Closing in favour of the conversation in #4497 and the out-of-tree experimentation in https://github.com/ehuss/cargo-index.

@dwijnand dwijnand closed this Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants