-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement generate-index-metadata command #6324
Implement generate-index-metadata command #6324
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks for the PR! Unfortunately now though there's a soft feature freeze in Cargo so it may be some time before the cargo team has bandwidth to review this |
As someone without much of the background context, I would like to see more documentation. What dose it do? How can it be used? How can it be configured? If my guess about what this does, I'd love to see an extenuation that let us take a resolution bug report and tern it into a reproducible test case. |
☔ The latest upstream changes (presumably #6347) made this pull request unmergeable. Please resolve the merge conflicts. |
95795ee
to
2a5ad7c
Compare
2a5ad7c
to
440939e
Compare
@alexcrichton was it freeze until rust 2018 release or is it freeze to the end of the year? |
cc @ehuss |
At this time I think we'd like to experiment with index-related commands out of tree. I'm putting together a new subcommand which provides several options for managing an index, which I'll be posting soon. Do you have interest in running a registry? If so, feedback and testing would be helpful to figure out what features are needed. |
This is my subcommand to create registry in a git repository: https://github.com/synek317/cargo-git-registry It is very much work in progress but with With |
@synek317 Nice! I'm trying to make it possible to implement this separately just using |
Closing in favour of the conversation in #4497 and the out-of-tree experimentation in https://github.com/ehuss/cargo-index. |
It solves the issue #4497