Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metabuild compile errors with --message-format=json. #6432

Merged
merged 3 commits into from
Dec 18, 2018
Merged

Fix metabuild compile errors with --message-format=json. #6432

merged 3 commits into from
Dec 18, 2018

Commits on Dec 18, 2018

  1. Fix metabuild compile errors with --message-format=json. 

    If an error occurs while compiling a metabuild target with
`--message-format=json`, it would panic because it was unable to serialize
`Target`. This change makes it so that it places a fake "metabuild.rs" string in
the `src_path` in this situation.

I'm very unhappy with this solution, but I'm unable to think of something
better. Changing `src_path` to an `Option` (or something) would break existing
tools. I tried implementing something that resets the `src_path` to the correct
path in the target dir after the workspace is configured, but it felt very
brittle – you have to fix up after all dependencies are downloaded, and there's
not a good way to ensure that happens correctly.

This adds a `with_json_contains_unordered` to help with tests.
    @ehuss
    ehuss committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    9a7fadf View commit details
    Browse the repository at this point in the history

  2. Switch SerializedTarget::src_path to None instead of using fake path.

    @ehuss
    ehuss committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    2a0bb65 View commit details
    Browse the repository at this point in the history

  3. Update metabuild test to 2018.

    @ehuss
    ehuss committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    48d56a4 View commit details
    Browse the repository at this point in the history