Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make incremental compilation the default for all profiles." #6610

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

alexcrichton
Copy link
Member

This reverts commit 2c40858.

@rust-highfive
Copy link

r? @Eh2406

(rust_highfive has picked a reviewer for you, use r? to override)

@Eh2406
Copy link
Contributor

Eh2406 commented Jan 28, 2019

r = me on the content. I won't tell bors, in case we decide to get a few more days of testing.

@alexcrichton
Copy link
Member Author

@bors: r=Eh2406

Ok I'm gonna go ahead and land this as it'll take some time to update the rust-lang/rust submodule anyway

@bors
Copy link
Contributor

bors commented Jan 28, 2019

📌 Commit b9da4d7 has been approved by Eh2406

@bors
Copy link
Contributor

bors commented Jan 28, 2019

⌛ Testing commit b9da4d7 with merge 2c4a411...

bors added a commit that referenced this pull request Jan 28, 2019
Revert "Make incremental compilation the default for all profiles."

This reverts commit 2c40858.
@bors
Copy link
Contributor

bors commented Jan 29, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Eh2406
Pushing 2c4a411 to master...

@johnthagen
Copy link
Contributor

@alexcrichton Should this be in the latest nightly at this point? I'm still having LTO Xargo build problems related to this on rustc 1.34.0-nightly (8ae730a44 2019-02-04): japaric/xargo#236

@ehuss
Copy link
Contributor

ehuss commented Feb 5, 2019

@johnthagen Yes, it will be turned off once rust-lang/rust#58131 lands. Unfortunately many people are at the Rust All Hands, so it may take some time.

bors added a commit to rust-lang/rust that referenced this pull request Feb 5, 2019
Update cargo

7 commits in 245818076052dd7178f5bb7585f5aec5b6c1e03e..4e74e2fc0908524d17735c768067117d3e84ee9c
2019-01-27 15:17:26 +0000 to 2019-02-02 17:48:44 +0000
- Fix overlapping progress with stdout. (rust-lang/cargo#6618)
- Improve progress bar flickering. (rust-lang/cargo#6615)
- Add detail to multiple rename deps (rust-lang/cargo#6603)
- Fix race condition in local registry crate unpacking (rust-lang/cargo#6591)
- Revert "Make incremental compilation the default for all profiles." (rust-lang/cargo#6610)
- Fixup the docs on crate-type (rust-lang/cargo#6606)
- Document that owner --add now just invites (rust-lang/cargo#6604)
@alexcrichton alexcrichton deleted the revert-incremental branch May 6, 2019 18:13
@ehuss ehuss added this to the 1.34.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants