Extract & re-use filter_targets in cargo_compile #6621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
ehuss
reviewed
Feb 3, 2019
Also drop part of the docs in `list_rule_targets`, as that info is now on `Proposal`.
dwijnand
force-pushed
the
clean-cargo_compile
branch
from
a1ce703 to
df9ca87
Compare
dwijnand
changed the title
|
@bors r+ |
|
📌 Commit df9ca87 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 4, 2019
Extract & re-use filter_targets in cargo_compile Also drop part of the docs in `list_rule_targets`, as that info is now on `Proposal`.
|
☀️ Test successful - checks-travis, status-appveyor |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Feb 10, 2019
Bump cargo to 865cb70 Merged PRs: * Replace util::without_prefix with Path::strip_prefix rust-lang/cargo#6620 * keep track of crates that are whitelisted to be used even if yanked rust-lang/cargo#6611 * Fix default DYLD_FALLBACK_LIBRARY_PATH on MacOS. rust-lang/cargo#6625 * Bail when trying to run "test --doc --no-run" rust-lang/cargo#6628 * In cargo test's help, add that examples are built rust-lang/cargo#6619 * Extract & re-use filter_targets in cargo_compile rust-lang/cargo#6621 * Test cleanup: remove unnecessary with_status(0) rust-lang/cargo#6630 * Fix run's help message rust-lang/cargo#6631 * Some updates to bash completion. rust-lang/cargo#6644 * Introduce Source::download_now rust-lang/cargo#6637 * Switch from unused_imports to deprecated to test unfixable warnings rust-lang/cargo#6649
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Feb 11, 2019
Bump cargo to 865cb70 Merged PRs: * Replace util::without_prefix with Path::strip_prefix rust-lang/cargo#6620 * keep track of crates that are whitelisted to be used even if yanked rust-lang/cargo#6611 * Fix default DYLD_FALLBACK_LIBRARY_PATH on MacOS. rust-lang/cargo#6625 * Bail when trying to run "test --doc --no-run" rust-lang/cargo#6628 * In cargo test's help, add that examples are built rust-lang/cargo#6619 * Extract & re-use filter_targets in cargo_compile rust-lang/cargo#6621 * Test cleanup: remove unnecessary with_status(0) rust-lang/cargo#6630 * Fix run's help message rust-lang/cargo#6631 * Some updates to bash completion. rust-lang/cargo#6644 * Introduce Source::download_now rust-lang/cargo#6637 * Switch from unused_imports to deprecated to test unfixable warnings rust-lang/cargo#6649
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also drop part of the docs in
list_rule_targets, as that info is now onProposal.