Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proptest 0.9.0, minimal Rust 1.32.0 #6636

Closed
wants to merge 2 commits into from
Closed

Proptest 0.9.0, minimal Rust 1.32.0 #6636

wants to merge 2 commits into from

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Feb 5, 2019

No description provided.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

r=me w/ green CI

@dwijnand
Copy link
Member Author

dwijnand commented Feb 5, 2019

Ah, breaking changes in rand making a (transitive?) dependency on rand_isaacs break. Oh well.

@dwijnand dwijnand closed this Feb 5, 2019
@dwijnand dwijnand deleted the proptest-0.9 branch February 5, 2019 13:43
@dwijnand dwijnand mentioned this pull request Feb 11, 2019
Closed
@Eh2406
Copy link
Contributor

Eh2406 commented Feb 11, 2019

This is unfortunate, I was looking forward to using some of the new toys in 0.9.1

@dwijnand
Copy link
Member Author

How are problems like this resolved in Rust?

@Eh2406
Copy link
Contributor

Eh2406 commented Feb 11, 2019

It looks like it is just minimal-versions that is not passing. As this is an unstable feature there is not yet much advice on how to fix it. Fundamentally, rand_isaac-0.1.0 is lying about the minimum version of SeedableRng that it supports.

@Eh2406
Copy link
Contributor

Eh2406 commented Feb 12, 2019

From a quick look rand 0.6.x is a hot mess with incorrect minimal-versions.

@dwijnand
Copy link
Member Author

Ok I spent a long time trying to make it work, following your guide in #5657 (comment) and reading lots of commits, comments and threads, and couldn't figure it out. If you have an advice I can continue trying.

@Eh2406
Copy link
Contributor

Eh2406 commented Feb 12, 2019

Thanks for spending the time! I spent some time trying to figure it out as well, but did not get far.

@ehuss ehuss mentioned this pull request Feb 13, 2019
Open
@ehuss ehuss mentioned this pull request Mar 15, 2019
Merged
Eh2406 added a commit to Eh2406/cargo that referenced this pull request Mar 16, 2019
@Eh2406
Proptest 0.9.1
ed9386b 
This is a rework of rust-lang#6636 now possible do to the change in testing from rust-lang#6748
@Eh2406 Eh2406 mentioned this pull request Mar 16, 2019
Merged
bors added a commit that referenced this pull request Mar 16, 2019
@bors
Auto merge of #6753 - Eh2406:proptest, r=dwijnand
7d09f17 
Proptest 0.9.1

This is a rework of #6636 now possible do to the change in testing from #6748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dwijnand @rust-highfive @alexcrichton @Eh2406 @dependabot-support