Test cases proving RUSTC_WRAPPER can be a relative path #6638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd love to not need to use env::current_dir(), but I couldn't find a way. Also I need to add a test for this. |
|
Seems plausible to me! This seems a bit deep though within Cargo for where this is handled, could it perhaps be handled at an outer layer where this wrapper is initially set? |
|
Hmm, maybe! I'll give it a shot. |
dwijnand
force-pushed
the
support-relative-RUSTC_WRAPPER
branch
2 times, most recently
from
58f1067
to
052a176
Compare
|
Review by @ehuss, perhaps? |
|
It looks like relative paths are already handled here, so perhaps it could be debugged why that's not working? |
dwijnand
force-pushed
the
support-relative-RUSTC_WRAPPER
branch
from
052a176
to
8c26860
Compare
dwijnand
changed the title
|
Turns out it was working... |
|
@bors: r+ Heh well that's a surprise! |
|
📌 Commit 8c26860 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 14, 2019
…crichton Test cases proving RUSTC_WRAPPER can be a relative path Test cases for #4865
|
☀️ Test successful - checks-travis, status-appveyor |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Feb 21, 2019
Update cargo 9 commits in 865cb70106a6b1171a500ff68f93ab52eea56e72..b33ce7fc9092962b0657b4c25354984b5e5c47e4 2019-02-10 15:49:37 +0000 to 2019-02-19 18:42:50 +0000 - Don't retry invalid credentials from git credential helpers (rust-lang/cargo#6681) - Fix some typos in resolver tests (rust-lang/cargo#6682) - Add an unstable option to build proc macros for both the host and the target (rust-lang/cargo#6547) - Test cases proving RUSTC_WRAPPER can be a relative path (rust-lang/cargo#6638) - Add support for Azure DevOps (rust-lang/cargo#6264) - Update docs for removed `patch` restriction. (rust-lang/cargo#6663) - Fix incorrect help message (rust-lang/cargo#6555) - Stabilize Alternative Registries (rust-lang/cargo#6654) - Having a [patch] section when publishing is not an error (rust-lang/cargo#6535)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cases for #4865