-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Support target configuration in workspace modules #7022
WIP: Support target configuration in workspace modules #7022
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
☔ The latest upstream changes (presumably #7116) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #7350) made this pull request unmergeable. Please resolve the merge conflicts. |
This has unfortunately been languishing for quite some time now so I'm gonna go ahead and close this. In general we'd reocmmend discussing design and sending a PR once the team is good to go on a new feature, unfortunately starting with failing tests tends to not have a ton of traction :( |
Does this mean that Cargo still completely ignores the |
I don't believe it completely ignores |
The target triple is the one thing that I need it to honor
…On Mon, Nov 4, 2019, 10:44 AM John Barker ***@***.***> wrote:
I don't believe it completely ignores .cargo/config, only the target
triple
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#7022?email_source=notifications&email_token=ADI4TIJ4IARMHS7TH6XCSE3QSA7PFA5CNFSM4HWH2SP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC7WG6A#issuecomment-549413752>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADI4TIMTBOGKWCOK64D5LF3QSA7PFANCNFSM4HWH2SPQ>
.
|
[Fixes #7004]