Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename to_url → into_url #7048

Merged
merged 2 commits into from
Jun 20, 2019
Merged

Rename to_url → into_url #7048

merged 2 commits into from
Jun 20, 2019

Conversation

jeremystucki
Copy link
Contributor

I think it should be into_url as it consumes itself.

Relevant clippy lint

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Eh2406 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 20, 2019
@jeremystucki jeremystucki changed the title Rename to_url -> into_url Rename to_url → into_url Jun 20, 2019
@Eh2406
Copy link
Contributor

Eh2406 commented Jun 20, 2019

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 20, 2019

📌 Commit 930134c has been approved by Eh2406

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2019
@bors
Copy link
Collaborator

bors commented Jun 20, 2019

⌛ Testing commit 930134c with merge f060b0a5386633db52dc38a74c9f212a6b75922c...

@Eh2406
Copy link
Contributor

Eh2406 commented Jun 20, 2019

Looks like it needs a cargo fmt before bors will let it merge.

@bors
Copy link
Collaborator

bors commented Jun 20, 2019

💔 Test failed - checks-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 20, 2019
@Eh2406
Copy link
Contributor

Eh2406 commented Jun 20, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 20, 2019

📌 Commit 2415a29 has been approved by Eh2406

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2019
@bors
Copy link
Collaborator

bors commented Jun 20, 2019

⌛ Testing commit 2415a29 with merge eebd1da...

bors added a commit that referenced this pull request Jun 20, 2019
@bors
Auto merge of #7048 - jeremystucki:into_url, r=Eh2406
eebd1da 
Rename to_url → into_url

I think it should be `into_url` as it consumes itself.

[Relevant clippy lint](https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention)
@bors
Copy link
Collaborator

bors commented Jun 20, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Eh2406
Pushing eebd1da to master...

@bors bors merged commit 2415a29 into rust-lang:master Jun 20, 2019
@jeremystucki jeremystucki deleted the into_url branch June 20, 2019 17:25
@jeremystucki jeremystucki restored the into_url branch June 20, 2019 17:31
@ehuss ehuss mentioned this pull request Jun 24, 2019
Merged
bors added a commit to rust-lang/rust that referenced this pull request Jun 24, 2019
@bors
Auto merge of #62100 - ehuss:update-cargo, r=alexcrichton
a5b1729 
Update cargo

17 commits in 807429e1b6da4e2ec52488ef2f59e77068c31e1f..4c1fa54d10f58d69ac9ff55be68e1b1c25ecb816
2019-06-11 14:06:10 +0000 to 2019-06-24 11:24:18 +0000
- Fix typo in comment (rust-lang/cargo#7066)
- travis: enforce formatting of subcrates as well (rust-lang/cargo#7063)
- _cargo: Make function style consistent (rust-lang/cargo#7060)
- Update some fix comments. (rust-lang/cargo#7061)
- Stabilize default-run (rust-lang/cargo#7056)
- Fix typo in comment (rust-lang/cargo#7054)
- fix(fingerpring): do not touch intermediate artifacts (rust-lang/cargo#7050)
- Resolver test/debug cleanup (rust-lang/cargo#7045)
- Rename to_url → into_url (rust-lang/cargo#7048)
- Remove needless lifetimes (rust-lang/cargo#7047)
- Revert test directory cleaning change. (rust-lang/cargo#7042)
- cargo book /reference/manifest: fix typo (rust-lang/cargo#7041)
- Extract resolver tests to their own crate (rust-lang/cargo#7011)
- ci: Do not install addons on rustfmt build jobs (rust-lang/cargo#7038)
- Support absolute paths in dep-info files (rust-lang/cargo#7030)
- ci: Run cargo fmt on all workspaces (rust-lang/cargo#7033)
- Deprecated ONCE_INIT in favor of Once::new() (rust-lang/cargo#7031)
@ehuss ehuss added this to the 1.37.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Eh2406 Eh2406

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.37.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jeremystucki @rust-highfive @Eh2406 @bors @ehuss