Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_cargo: Add cargo package completion #7064

Closed
wants to merge 3 commits into from

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jun 23, 2019

Continuation of #7060
r? @ehuss

Sublime Text couldn't handle the parameter expansion correctly.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2019
@tesuji
Copy link
Contributor Author

tesuji commented Jun 23, 2019

Ran on cargo repository:
asciicast

@tesuji
Copy link
Contributor Author

tesuji commented Jun 24, 2019

Ping @ehuss

@ehuss
Copy link
Contributor

ehuss commented Jun 25, 2019

This seems kinda buggy. For example, the completion includes backslashes and whitespace sometimes.

Also, reading the manifest is a poor way to find the valid values for -p.

I personally would prefer to avoid spending any time enhancing these completion files (anything beyond trivial changes) and wait for #6645. If you want to help with #6645, that would be appreciated! The approach for that will be substantially different, using rust code to drive the completions which should be much easier to implement, test, etc.

@tesuji
Copy link
Contributor Author

tesuji commented Jun 26, 2019

Could you give an example how is this bugged?

@ehuss
Copy link
Contributor

ehuss commented Jun 30, 2019

Doing completion in cargo's own repo: > cargo build -p=clap\ .
This is on macOS: zsh 5.7.1 (x86_64-apple-darwin18.2.0)

But as I said, I'd rather not spend time reviewing or maintaining this code, since we intend to remove it.

@alexcrichton
Copy link
Member

I'm going to close this since it's been quiet for a bit and due to @ehuss's previous comments.

@tesuji tesuji deleted the zsh-complete-package branch July 23, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants