Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial working version of cargo fix --clippy #7069

Merged
merged 22 commits into from
Jul 19, 2019
Merged

initial working version of cargo fix --clippy #7069

merged 22 commits into from
Jul 19, 2019

Commits on Jun 24, 2019

  1. initial working version of cargo fix --clippy

    @yaahc
    yaahc committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    c057a06 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2019

  1. initial attempt at argument passthrough

    @yaahc
    yaahc committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    0a943be View commit details
    Browse the repository at this point in the history

  2. nailed it

    @yaahc
    yaahc committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    4f64aaa View commit details
    Browse the repository at this point in the history

  3. appease cargo fmt

    @yaahc
    yaahc committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    c492205 View commit details
    Browse the repository at this point in the history

  4. rename passthru arg to make it clearer 

    the clippy args passthrough only allows one arg per instance of the flag
and does not resplit on spaces, as such it should be more obvious to the
user that you need to specify the flag once per clippy argument.
    @yaahc
    yaahc committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    6b233cb View commit details
    Browse the repository at this point in the history

  5. initial clippy tests

    @yaahc
    yaahc committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    3a9ac3e View commit details
    Browse the repository at this point in the history

  6. use json instead of shitty hack

    @yaahc
    yaahc committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    65afb3f View commit details
    Browse the repository at this point in the history

  7. add warning to cargo incase clippy is missing 

    This is only a warning because rustup(?) already warns and is much more
verbose about how to recover from the error, so I would like to call
into the clippy-driver shim or w/e is outputting nice error messages.

But incase rustup is not available or some other shenanigans occur,
cargo will also output the warning so the error isn't a mystery.
    @yaahc
    yaahc committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    ad909ac View commit details
    Browse the repository at this point in the history

  8. allow clippy path override via env variable

    @yaahc
    yaahc committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    d076f44 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. Update src/bin/cargo/commands/fix.rs 

    Co-Authored-By: Eric Huss <eric@huss.org>
    @yaahc @ehuss
    yaahc and ehuss authored Jun 26, 2019
    Configuration menu
    Copy the full SHA
    4ff4c1f View commit details
    Browse the repository at this point in the history

  2. Update src/cargo/util/config.rs 

    Co-Authored-By: Eric Huss <eric@huss.org>
    @yaahc @ehuss
    yaahc and ehuss authored Jun 26, 2019
    Configuration menu
    Copy the full SHA
    85ba8e9 View commit details
    Browse the repository at this point in the history

  3. some changes, ill clean this up in a hot sec

    @yaahc
    yaahc committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    6fb65f1 View commit details
    Browse the repository at this point in the history

  4. back in tip top shape

    @yaahc
    yaahc committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    8b1f599 View commit details
    Browse the repository at this point in the history

  5. it was still a little broken

    @yaahc
    yaahc committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    fefcca1 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2019

  1. Fix --clippy arg for fix

    @yaahc
    yaahc committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    b9f3c16 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2019

  1. centralize diagnostic server stuff

    @yaahc
    yaahc committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    abd9149 View commit details
    Browse the repository at this point in the history

  2. implement primary unit rustc

    @yaahc
    yaahc committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    46b48f6 View commit details
    Browse the repository at this point in the history

  3. deduplicate code

    @yaahc
    yaahc committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    1818096 View commit details
    Browse the repository at this point in the history

  4. missing wiring

    @yaahc
    yaahc committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    c0c6729 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2019

  1. minor fixes

    @yaahc
    yaahc committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    f3d3318 View commit details
    Browse the repository at this point in the history

  2. apply the correct changes

    @yaahc
    yaahc committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    03feb61 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2019

  1. dont overuse the wrapper

    @yaahc
    yaahc committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    22b430d View commit details
    Browse the repository at this point in the history