Allow git dependency with shorthand ssh submodules to work. #7238
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ Yeah this seems fine to verify manually, no worries on the test! |
|
📌 Commit 0400879 has been approved by |
bors
added
S-waiting-on-bors
Allow git dependency with shorthand ssh submodules to work. If a submodule is defined with a shorthand ssh url (like `git@github.com/user/repo.git`), then cargo was choking on it trying to convert it to a URL. The fix is to just pass around strings. An alternate solution would be to try to detect shorthand git urls and automatically add `ssh://` to the path. I'm concerned about matching git's heuristics for this, though. I'm willing to try if you think this would be better, though. I can't think of a good way to write a test for this, since we don't have any SSH test infrastructure. I verified running locally against github. Closes #7202
|
☀️ Test successful - checks-azure |
This is a small breaking change in cargo, because they no longer try to normalize urls: rust-lang/cargo#7238
|
Hey guys, I've just spent a decent amount of time debugging both This is a small breaking change (since double slashes with no host are non-standard), but I just want to notify you about this fact. |
|
@Veetaha this is almost a year old so if it's causing issues it's probably best to open a fresh issue with fresh details to track anything necessary |
This is a small breaking change in cargo, because they no longer try to normalize urls: rust-lang/cargo#7238
This is a small breaking change in cargo, because they no longer try to normalize urls: rust-lang/cargo#7238
If a submodule is defined with a shorthand ssh url (like
git@github.com/user/repo.git), then cargo was choking on it trying to convert it to a URL. The fix is to just pass around strings.An alternate solution would be to try to detect shorthand git urls and automatically add
ssh://to the path. I'm concerned about matching git's heuristics for this, though. I'm willing to try if you think this would be better, though.I can't think of a good way to write a test for this, since we don't have any SSH test infrastructure. I verified running locally against github.
Closes #7202