Allow git dependency with shorthand ssh submodules to work. #7238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a submodule is defined with a shorthand ssh url (like
git@github.com/user/repo.git
), then cargo was choking on it trying to convert it to a URL. The fix is to just pass around strings.An alternate solution would be to try to detect shorthand git urls and automatically add
ssh://
to the path. I'm concerned about matching git's heuristics for this, though. I'm willing to try if you think this would be better, though.I can't think of a good way to write a test for this, since we don't have any SSH test infrastructure. I verified running locally against github.
Closes #7202