-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo install
: Remove orphaned executables.
#7246
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Seems reasonable to me! I'd propose leaving this as-is, so... @rfcbot fcp merge |
Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
@bors r=alexcrichton |
📌 Commit 5a59b80 has been approved by |
`cargo install`: Remove orphaned executables. When a new version of a package is installed that no longer contains an executable from a previous version, this change causes those orphaned executables to also be removed. I can place this new behavior behind the `install-upgrade` feature gate if anyone is uncomfortable with changing the behavior now. cc #6797
☀️ Test successful - checks-azure |
When a new version of a package is installed that no longer contains an executable from a previous version, this change causes those orphaned executables to also be removed.
I can place this new behavior behind the
install-upgrade
feature gate if anyone is uncomfortable with changing the behavior now.cc #6797