Don't build libstd as a dylib
#7353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ehuss (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This commit forcibly prevents Cargo from building the `std` crate as a `dylib`, even though libstd upstream lists a `dylib` crate type. We ideally want a first-class feature for doing this one day, but for now we can just hack around with the manifests to ensure that the `dylib` crate type never shows up. Note that this is only supported for libstd, and it's also all part of the unstable details of building std. Closes rust-lang/wg-cargo-std-aware#35
alexcrichton
force-pushed
the
libstd-no-dylib
branch
from
89a07e2
to
70bea01
Compare
|
Should be fine for now. @bors r+ |
|
📌 Commit 70bea01 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 11, 2019
Don't build libstd as a `dylib` This commit forcibly prevents Cargo from building the `std` crate as a `dylib`, even though libstd upstream lists a `dylib` crate type. We ideally want a first-class feature for doing this one day, but for now we can just hack around with the manifests to ensure that the `dylib` crate type never shows up. Note that this is only supported for libstd, and it's also all part of the unstable details of building std. Closes rust-lang/wg-cargo-std-aware#35
|
☀️ Test successful - checks-azure |
|
Could this be used by xargo somehow? We'd also be interested in rlib-only builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit forcibly prevents Cargo from building the
stdcrate as adylib, even though libstd upstream lists adylibcrate type. Weideally want a first-class feature for doing this one day, but for now
we can just hack around with the manifests to ensure that the
dylibcrate type never shows up. Note that this is only supported for libstd,
and it's also all part of the unstable details of building std.
Closes rust-lang/wg-cargo-std-aware#35