Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Go back to not hashing RUSTFLAGS in -Cmetadata #7459

Merged
merged 2 commits into from
Sep 30, 2019
Merged

[beta] Go back to not hashing RUSTFLAGS in -Cmetadata #7459

merged 2 commits into from
Sep 30, 2019

Commits on Sep 30, 2019

  1. Go back to not hashing RUSTFLAGS in -Cmetadata 

    This is a moral revert of rust-lang#6503 but not a literal code revert. This
switches Cargo's behavior to avoid hashing compiler flags into
`-Cmetadata` since we've now had multiple requests of excluding flags
from the `-Cmetadata` hash: usage of `--remap-path-prefix` and PGO
options. These options should only affect how the compiler is
invoked/compiled and not radical changes such as symbol names, but
symbol names are changed based on `-Cmetadata`. Instead Cargo will still
track these flags internally, but only for reinvoking rustc, and not for
caching separately based on rustc flags.

Closes rust-lang#7416
    @alexcrichton
    alexcrichton committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    be712ff View commit details
    Browse the repository at this point in the history

  2. Run rustfmt

    @alexcrichton
    alexcrichton committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    e2637c0 View commit details
    Browse the repository at this point in the history