Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #7563 #7564

Closed
Closed

Conversation

12101111
Copy link

@12101111 12101111 commented Nov 6, 2019

Fix building proc-macro crates on musl host when --target is specified.

Fix building proc-macro crates on musl host when --target is specified.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 6, 2019
@alexcrichton
Copy link
Member

Thanks for the PR!

I'm not sure that Cargo has a great way to fix this though. Cargo in general doesn't want to configure and/or encode platform-specific settings, but rather provide the knobs for the configuration to be passed down to Cargo. Cargo doesn't have a great way to specify flags for "only host compilations" today, and that's a known bug in Cargo.

@ehuss
Copy link
Contributor

ehuss commented Feb 3, 2020

I'm going to close this due to inactivity.

I think figuring out how to handle proc-macro and musl should be discussed on rust-lang/rust. rust-lang/rust#40174 and rust-lang/rust#59302 seem like the correct places to work out what to do. If I had to take a wild guess, I would say rust-lang/rust#40174 (comment) sounds promising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants