Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a broken link in CONTRIBUTING.md #7632

Closed
wants to merge 1 commit into from
Closed

Fix a broken link in CONTRIBUTING.md #7632

wants to merge 1 commit into from

Conversation

giraffate
Copy link
Contributor

testsuite/support/mod.rs is replaced at 9115b2c.

@giraffate
Fix a broken link in CONTRIBUTING.md [ci skip]
e63d98e 
`testsuite/support/mod.rs` is replaced at 9115b2c.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 26, 2019
@ehuss
Copy link
Contributor

ehuss commented Nov 26, 2019

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Nov 26, 2019

📌 Commit e63d98e has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2019
@bors
Copy link
Contributor

bors commented Nov 26, 2019

⌛ Testing commit e63d98e with merge ccb8a41ab37a0806071db33db82e50dc0c63c831...

@bors
Copy link
Contributor

bors commented Nov 26, 2019

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 26, 2019
@alexcrichton
Copy link
Member

@bors: retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2019
@bors
Copy link
Contributor

bors commented Nov 26, 2019

⌛ Testing commit e63d98e with merge b13dddfb5942c2e02fc22279d583a3bbcd1b88bb...

@bors
Copy link
Contributor

bors commented Nov 26, 2019

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 26, 2019
@giraffate
Copy link
Contributor Author

hmm, test timed out 👀

@ehuss
Copy link
Contributor

ehuss commented Nov 27, 2019

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2019
@bors
Copy link
Contributor

bors commented Nov 27, 2019

⌛ Testing commit e63d98e with merge a82922a5bfa332f324ed8dab1edb0acdb833a517...

@bors
Copy link
Contributor

bors commented Nov 27, 2019

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 27, 2019
@ehuss ehuss reopened this Nov 27, 2019
@ehuss
Copy link
Contributor

ehuss commented Nov 27, 2019

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2019
@bors
Copy link
Contributor

bors commented Nov 27, 2019

⌛ Testing commit e63d98e with merge 7027151...

bors added a commit that referenced this pull request Nov 27, 2019
@bors
Auto merge of #7632 - giraffate:fix_the_broken_link_in_contributing_m…
7027151 
…d, r=ehuss

Fix a broken link in CONTRIBUTING.md [ci skip]

`testsuite/support/mod.rs` is replaced at 9115b2c.
@bors
Copy link
Contributor

bors commented Nov 27, 2019

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 27, 2019
@giraffate
Copy link
Contributor Author

Hi, I don't know why time-out happens, but is there anything I can do to solve it?

@ehuss ehuss mentioned this pull request Nov 30, 2019
Merged
@ehuss
Copy link
Contributor

ehuss commented Nov 30, 2019

I'm not sure why it is timing out. I rolled up the commit into #7642, so hopefully it will pass over there.

@giraffate
Copy link
Contributor Author

Ok, thank you!

@giraffate giraffate mentioned this pull request Dec 2, 2019
Closed
@alexcrichton alexcrichton changed the title Fix a broken link in CONTRIBUTING.md [ci skip] Fix a broken link in CONTRIBUTING.md Dec 2, 2019
@alexcrichton
Copy link
Member

@bors: retry

I've removed "ci skip" from the title which I think was causing issues.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2019
@bors
Copy link
Contributor

bors commented Dec 2, 2019

⌛ Testing commit e63d98e with merge 8ad31675a58fc947c2b2481340244a1a62c2c2a6...

@bors
Copy link
Contributor

bors commented Dec 2, 2019

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 2, 2019
bors added a commit that referenced this pull request Dec 2, 2019
@bors
Auto merge of #7642 - ehuss:update-contributing, r=alexcrichton
ecf73d4 
Various contributing docs updates.

Various updates to the contributing docs for running tests, building docs, etc.

This also includes the commit from #7632, which for some reason azure is having trouble getting started.
@bors
Copy link
Contributor

bors commented Dec 2, 2019

☔ The latest upstream changes (presumably #7642) made this pull request unmergeable. Please resolve the merge conflicts.

@ehuss
Copy link
Contributor

ehuss commented Dec 2, 2019

This got rolled up in #7642. 😃

@ehuss ehuss closed this Dec 2, 2019
@giraffate giraffate deleted the fix_the_broken_link_in_contributing_md branch December 3, 2019 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehuss ehuss

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@giraffate @rust-highfive @ehuss @bors @alexcrichton