Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various doc updates #7733

Merged
merged 28 commits into from
Dec 22, 2019
Merged

Various doc updates #7733

merged 28 commits into from
Dec 22, 2019

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Dec 21, 2019

This is a collection of documentation updates that have been in my todo list for a while. Each change is in a separate commit.

The "features" chapter will probably get significant changes in the future, as it is pretty bare right now. Similarly the "workspace" chapter could probably use more examples.

Closes #3062
Closes #3817
Closes #3971
Closes #4212
Closes #4438
Closes #4756
Closes #5822
Closes #6913
Closes #7055

This attempts to be clearer about the requirements for crates.io publishing.

This also includes some other clarifications around various fields and specifying dependencies.

Closes rust-lang#3971
Closes rust-lang#7055
@rust-highfive
Copy link

r? @Eh2406

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 21, 2019
Copy link
Contributor

@Eh2406 Eh2406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like maybe you did not add the new overriding-dependencies.md to this commit, or I am just misunderstanding.

@ehuss
Copy link
Contributor Author

ehuss commented Dec 22, 2019

Looks like maybe you did not add the new overriding-dependencies.md to this commit, or I am just misunderstanding.

Oh thanks! Fixed.

@Eh2406
Copy link
Contributor

Eh2406 commented Dec 22, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Dec 22, 2019

📌 Commit 493eb34 has been approved by Eh2406

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 22, 2019
@bors
Copy link
Contributor

bors commented Dec 22, 2019

⌛ Testing commit 493eb34 with merge 741f0e5...

bors added a commit that referenced this pull request Dec 22, 2019
Various doc updates

This is a collection of documentation updates that have been in my todo list for a while. Each change is in a separate commit.

The "features" chapter will probably get significant changes in the future, as it is pretty bare right now. Similarly the "workspace" chapter could probably use more examples.

Closes #3062
Closes #3817
Closes #3971
Closes #4212
Closes #4438
Closes #4756
Closes #5822
Closes #6913
Closes #7055
@bors
Copy link
Contributor

bors commented Dec 22, 2019

☀️ Test successful - checks-azure
Approved by: Eh2406
Pushing 741f0e5 to master...

@bors bors merged commit 493eb34 into rust-lang:master Dec 22, 2019
bors added a commit that referenced this pull request Mar 10, 2020
Support old html anchors in manifest chapter.

#7733 unintentionally broke some old HTML anchors in the manifest chapter.  This would cause any links out in the wild to not scroll to the correct position.

Unfortunately it is too late for the 1.42 release.  However, I'd like to backport this for 1.43.
phil-opp added a commit to phil-opp/blog_os that referenced this pull request Mar 13, 2020
Move occured in rust-lang/cargo#7733 and was just released together with Rust 1.42.
ehuss pushed a commit to ehuss/cargo that referenced this pull request Mar 16, 2020
…crichton

Support old html anchors in manifest chapter.

rust-lang#7733 unintentionally broke some old HTML anchors in the manifest chapter.  This would cause any links out in the wild to not scroll to the correct position.

Unfortunately it is too late for the 1.42 release.  However, I'd like to backport this for 1.43.
@ehuss ehuss added this to the 1.42.0 milestone Feb 6, 2022
@epage epage mentioned this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment