Fix dynamic linking for Windows UWP MSVC targets #7758
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a dynamic library, the MSVC linker generates an import library (.lib) next to the .dll file. Cargo has explicit knowledge of this and includes those generated .dll.lib on the list of files generated by a Cargo invocation.
However, the check to see if those import libraries must be included is too strict and doesn't match any Windows targets that don't end in
pc-windows-msvc
. For example, rust-lang/rust#63155 added several new Windows targets for targeting UWP called*-uwp-windows-msvc
. The end result is that the sysroot for these UWP toolchains don't contain astd-XXX.dll.lib
file and thus any executable that uses-C prefer-dynamic
will fail to link because thestd
library is not linked at all.This change relaxes the test and makes Cargo know about those import libraries for all Windows MSVC targets.