Fix cache replay including extra newlines. #7819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ |
|
📌 Commit 34ab15be23b16c4fc790c7eb0eb39762cdec7bd8 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 34ab15be23b16c4fc790c7eb0eb39762cdec7bd8 with merge 8e75893dc66a46b9087666a780d3957e99404d7c... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
@bors: retry hoping spurious timeout |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 34ab15be23b16c4fc790c7eb0eb39762cdec7bd8 with merge befc8adcd1028154358446c3e3ff425dcbcadd32... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
ehuss
force-pushed
the
fix-replay-newlines
branch
from
34ab15b to
7be3c2f
Compare
|
I pushed a fix that should fix the Windows error. I forgot that Windows treats PATH a little differently, and there was an infinite loop where the |
|
@bors: r+ |
|
📌 Commit 7be3c2f has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 22, 2020
Fix cache replay including extra newlines. The compiler output cache replay was changed in #7737 to use `BufReader::read_line` instead of `str::lines`. `read_line`, unlike `lines`, includes the trailing line ending. The code is written assuming that the line endings are stripped, so make sure they are stripped here, too. This only happens for non-JSON messages, like `RUSTC_LOG`.
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler output cache replay was changed in #7737 to use
BufReader::read_lineinstead ofstr::lines.read_line, unlikelines, includes the trailing line ending. The code is written assuming that the line endings are stripped, so make sure they are stripped here, too.This only happens for non-JSON messages, like
RUSTC_LOG.