[WIP] Checking for ssh scheme before trying to set_scheme as https...

[deg4uss3r]

...This resulted in a return value of (). Creating a new workspace with an ssh call, will cause an error when trying to parse this dependency.

This happens when using cargo as an API to create a new workspace like in cargo-outdated, specially here. It was reported to us in issue kbknapp/cargo-outdated#195

I am very happy to discuss this PR and make any other changes recommend (or add this fix onto another branch). I chose the rust-1.40.0 branch because that is what we are currently testing on, thus would only have this change in the diff for better visibility.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[rust-highfive]

⚠️ Warning ⚠️

• Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.40.0. Please double check that you specified the right target!

[ehuss]

We generally don't make changes to older releases. It looks like this has already been fixed by #7787. I think if you lock Cargo.lock to an older release of the URL crate it should work. Otherwise, you may need to wait for the 0.43 release. Or you can ask for the URL crate to yank the version(s) with the breaking change.

[deg4uss3r]

Thanks @ehuss I’ll wait for 0.43.0 and lock the Url crate for now, sorry I missed that.

[ehuss]

Sure, no worries!