Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tar. #7874

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Update tar. #7874

merged 1 commit into from
Feb 6, 2020

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Feb 6, 2020

Updates to the latest tar. rust-lang/rust is currently on 0.4.20. The change I'm most interested in is fixing the TarError cause/source, so that Cargo reports a better error message. Compare:

Caused by:
  failed to unpack `/…/registry/src/github.com-1ecc6299db9ec823/curl-sys-0.4.25/curl/docs/libcurl/libcurl-multi.3`

to the new version:

Caused by:
  failed to unpack `curl-sys-0.4.25/curl/docs/libcurl/libcurl-multi.3` into `/…/registry/src/github.com-1ecc6299db9ec823/curl-sys-0.4.25/curl/docs/libcurl/libcurl-multi.3`

Caused by:
  No space left on device (os error 28)

@rust-highfive
Copy link

r? @Eh2406

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 6, 2020
@Eh2406
Copy link
Contributor

Eh2406 commented Feb 6, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Feb 6, 2020

📌 Commit 635c423 has been approved by Eh2406

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2020
@bors
Copy link
Contributor

bors commented Feb 6, 2020

⌛ Testing commit 635c423 with merge 23ce747...

bors added a commit that referenced this pull request Feb 6, 2020
Update tar.

Updates to the latest tar.  rust-lang/rust is currently on 0.4.20.  The change I'm most interested in is fixing the TarError cause/source, so that Cargo reports a better error message.  Compare:

```
Caused by:
  failed to unpack `/…/registry/src/github.com-1ecc6299db9ec823/curl-sys-0.4.25/curl/docs/libcurl/libcurl-multi.3`
```

to the new version:

```
Caused by:
  failed to unpack `curl-sys-0.4.25/curl/docs/libcurl/libcurl-multi.3` into `/…/registry/src/github.com-1ecc6299db9ec823/curl-sys-0.4.25/curl/docs/libcurl/libcurl-multi.3`

Caused by:
  No space left on device (os error 28)
```
@bors
Copy link
Contributor

bors commented Feb 6, 2020

☀️ Test successful - checks-azure
Approved by: Eh2406
Pushing 23ce747 to master...

@bors bors merged commit 635c423 into rust-lang:master Feb 6, 2020
@ehuss ehuss added this to the 1.43.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants