Clear RUSTDOCFLAGS before running tests
#8168
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Thanks! I think though a better place for this might perhaps be in this function? That way we'd catch it for all future tests too |
ecstatic-morse
force-pushed
the
future-proof-test
branch
from
cb790d6 to
cf57ce1
Compare
ecstatic-morse
changed the title
RUSTDOCFLAGSRUSTDOCFLAGS before running tests
Indeed! That's much better. |
|
@bors: r+ |
|
📌 Commit cf57ce1 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
Update cargo 11 commits in 8751eb3010d4cdb5329b5a6bd2b6d765c95b0dca..90931d9b31e8b854522fed00916504a3ac6d8619 2020-04-21 18:04:35 +0000 to 2020-04-28 01:56:59 +0000 - Use associated constants directly on primitive types instead of modules (rust-lang/cargo#8077) - Clear `RUSTDOCFLAGS` before running tests (rust-lang/cargo#8168) - Fix warning for `resolve` mismatch in workspace. (rust-lang/cargo#8169) - Fix flaky linking_interrupted test. (rust-lang/cargo#8162) - Fixed some unnecessary borrows and clones. (rust-lang/cargo#8146) - Added warning when using restricted names in Windows. (rust-lang/cargo#8136) - Add changelog about dylib uplift. (rust-lang/cargo#8161) - Mention that cargo_metadata can parse json messages (rust-lang/cargo#8158) - Re-enable rustc-info-cache test again (rust-lang/cargo#8155) - Updates to path source walking. (rust-lang/cargo#8095) - Bump to 0.46.0, update changelog (rust-lang/cargo#8153)
It turns out that this test will fail if
RUSTDOCFLAGSis set in the test runner. This was found inrust-lang/rust#71458 (comment) when that PR attempted to set the proper
RUSTDOCFLAGSto enable./x.py doc --stage 0 src/libstd. Run the test with noRUSTDOCFLAGSso that the config file always gets used.