Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "--target-dir" in "cargo install" #8391

Merged
merged 5 commits into from
Jun 23, 2020

Conversation

bl2e
Copy link
Contributor

@bl2e bl2e commented Jun 21, 2020

Issue #8263

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Eh2406 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 21, 2020
@bl2e bl2e force-pushed the install-target-dir branch from 00299e3 to bb37542 Compare June 21, 2020 06:14
@alexcrichton
Copy link
Member

@bors: r+

Thanks! I'm gonna go ahead and merge this since I believe the team already talked about it, but if someone has second thoughts please let me know!

@bors
Copy link
Contributor

bors commented Jun 23, 2020

📌 Commit 538d925 has been approved by alexcrichton

@alexcrichton alexcrichton reopened this Jun 23, 2020
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2020
@bors
Copy link
Contributor

bors commented Jun 23, 2020

⌛ Testing commit 538d925 with merge e6c9657072bcbde22812b5754fa074208b403fd5...

@alexcrichton
Copy link
Member

@bors: r+

er, that's not how you approve...

@bors
Copy link
Contributor

bors commented Jun 23, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Jun 23, 2020

📌 Commit 538d925 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jun 23, 2020

⌛ Testing commit 538d925 with merge fd600f3...

@bors
Copy link
Contributor

bors commented Jun 23, 2020

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing fd600f3 to master...

@bors bors merged commit fd600f3 into rust-lang:master Jun 23, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 24, 2020
Update cargo

9 commits in 089cbb80b73ba242efdcf5430e89f63fa3b5328d..c26576f9adddd254b3dd63aecba176434290a9f6
2020-06-15 14:38:34 +0000 to 2020-06-23 16:21:21 +0000
- Adding environment variable CARGO_PKG_LICENSE_FILE (rust-lang/cargo#8387)
- Enable "--target-dir" in "cargo install" (rust-lang/cargo#8391)
- Add support for `workspace.metadata` table (rust-lang/cargo#8323)
- Fix overzealous `clean -p` for reserved names. (rust-lang/cargo#8398)
- Fix order-dependent feature resolution. (rust-lang/cargo#8395)
- Correct mispelling of `cargo`. (rust-lang/cargo#8389)
- Add missing license field. (rust-lang/cargo#8386)
- Adding environment variable CARGO_PKG_LICENSE (rust-lang/cargo#8325)
- Cut down on data fetch from git dependencies (rust-lang/cargo#8363)
@ehuss ehuss added this to the 1.46.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants