Switch to github actions #8467
Switch to github actions #8467
Conversation
|
r? @ehuss (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| https://raw.githubusercontent.com/rust-lang/rust/master/src/tools/linkchecker/linkcheck.sh | ||
| sh linkcheck.sh --all cargo | ||
|
|
||
| success: |
There was a problem hiding this comment.
This is some trickery here to get bors to work. Bors can only listen for one status on a PR, but GitHub Actions creates a status-per-builder. This "bors build finished" status is intended to be the signal to bors that the build has finished. This is mostly just copied from rust-lang/rust. I'm hoping that bors-rs may make this a bit nicer so we don't have to do this in the future.
alexcrichton
force-pushed
the
gha
branch
4 times, most recently
from
da69065
to
cb1ac66
Compare
|
I think the corresponding bors changes look like rust-lang/rust-central-station#890 |
|
Ok, should now be 100% faithful to azure pipelines! |
|
Thanks! r=me if you're ready. (I'm not sure if you have to do the bors change concurrently.) |
|
Ok I'll work with bors/rust-central-station to get this merged. |
|
Ok let's see if this works... @bors: r+ |
|
📌 Commit 2258f60f9854b8e005bd44525b84127f4370724e has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 2258f60f9854b8e005bd44525b84127f4370724e with merge 2c53bfa555bd0a848f2759a7fabf3250f8153f31... |
|
@bors: r=ehuss |
|
📌 Commit 1ceefa5 has been approved by |
Switch to github actions This commit switches our CI from Azure Pipelines to GitHub Actions. The intention here is to follow the "idiomatic" provider of CI for rust-lang, and otherwise GitHub Actions is better integrated with GitHub's UI right now too. I'll need to tweak bors to actually `@bors: r+` this to have it successfully get merged, but I think it'd be good to get some review first.
|
☀️ Test successful - checks-actions |
|
Ok so tests passed on the merge commit, the "bors build finished" status came up green, and the commit was actually indeed pushed to the master branch. The PR wasn't auto-closed, however. AFAIK auto-closing is a feature of GitHub, not bors, so this may just be an unlucky intermittent issue on their end? I'll close this manually for now, but we should watch the next PR closely! |
Update cargo 21 commits in 43cf77395cad5b79887b20b7cf19d418bbd703a9..aa6872140ab0fa10f641ab0b981d5330d419e927 2020-07-13 17:35:42 +0000 to 2020-07-23 13:46:27 +0000 - Update features set in CI. (rust-lang/cargo#8530) - Stabilize -Z crate-versions (rust-lang/cargo#8509) - Fix typo in docs (rust-lang/cargo#8529) - Remove unused CompileMode::all_modes (rust-lang/cargo#8526) - Mask out system core.autocrlf settings before resetting git repos (rust-lang/cargo#8523) - Flag git zlib errors as spurious errors (rust-lang/cargo#8520) - Fix the help display for the target-triple option (rust-lang/cargo#8515) - Check workspace member existence as dir. (rust-lang/cargo#8511) - Bump to 0.48.0, update changelog (rust-lang/cargo#8508) - Apply workspace.exclude to workspace.default-members. (rust-lang/cargo#8485) - Fix nightly tests for intra-doc links. (rust-lang/cargo#8528) - doc: Replace "regenerate" with "revoke" for API tokens (rust-lang/cargo#8510) - Add back Manifest::targets_mut (rust-lang/cargo#8494) - Build host dependencies with opt-level 0 by default (rust-lang/cargo#8500) - Fix freshness checks for build scripts on renamed dirs (rust-lang/cargo#8497) - Add a `-Zbuild-std-features` flag (rust-lang/cargo#8490) - clippy cleanups (rust-lang/cargo#8495) - Fix self-publish script. (rust-lang/cargo#8492) - Ensure `unstable.build-std` works like `-Zbuild-std` (rust-lang/cargo#8491) - Make `cargo metadata` output deterministic (rust-lang/cargo#8489) - Switch to github actions (rust-lang/cargo#8467)
This commit switches our CI from Azure Pipelines to GitHub Actions. The intention here is to follow the "idiomatic" provider of CI for rust-lang, and otherwise GitHub Actions is better integrated with GitHub's UI right now too.
I'll need to tweak bors to actually
@bors: r+this to have it successfully get merged, but I think it'd be good to get some review first.