Cargo book nitpick in Manifest section #8543
Conversation
Update fork
The Manifest section states on the example that the default edition is 2018, but the lines of text avobe state that the default is `2015` which is not correct. Closes rust-lang#8541
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Eh2406 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ Thank you! |
|
📌 Commit 6f8546f has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
This is incorrect, would you mind reverting it? The default is 2015. The examples aren't there to show the defaults (for example, the |
|
If you create a new lib with the latest stable with That's why I did the change @ehuss |
|
Yes, the default for |
|
My apologies then. |
|
I to apologize, I should have read more carefully before reviewing. |
|
@CPerezz do you want to make a PR fixing it back or would you like me to? |
|
I'll do it!
And again, sorry for the inconvenience.
El dl., 27 de jul. 2020, 21:10, Jacob Finkelman <notifications@github.com>
va escriure:
… @CPerezz <https://github.com/CPerezz> do you want to make a PR fixing it
back or would you like me to?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8543 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI4J4HVJCZJSSQP3ISTCK6LR5XGLNANCNFSM4PHDFVCQ>
.
|
On rust-lang#8543 it was introduced a change on the Cargo Book docs where it was incorrectly stated that the default edition for the Cargo Manifest was `2018` when indeed, as @ehuss correctly stated in rust-lang#8543 (comment) it is not. Therefore, as @Eh2406 asked for, I made the PR reverting this changes and leaving the Cargo Book docs as they were before.
Revert Cargo Book changes for default edition On #8543 it was introduced a change on the Cargo Book docs where it was incorrectly stated that the default edition for the Cargo Manifest was `2018` when indeed, as @ehuss correctly stated in #8543 (comment) it is not. Therefore, as @Eh2406 asked for, I made the PR reverting this changes and leaving the Cargo Book docs as they were before.
Update cargo 14 commits in aa6872140ab0fa10f641ab0b981d5330d419e927..974eb438da8ced6e3becda2bbf63d9b643eacdeb 2020-07-23 13:46:27 +0000 to 2020-07-29 16:15:05 +0000 - Fix O0 build scripts by default without `[profile.release]` (rust-lang/cargo#8560) - Emphasize git dependency version locking behavior. (rust-lang/cargo#8561) - Update lock file encodings on changes (rust-lang/cargo#8554) - Fix sporadic lto test failures. (rust-lang/cargo#8559) - build-std: Fix libraries paths following upstream (rust-lang/cargo#8558) - Flag git http errors as maybe spurious (rust-lang/cargo#8553) - Display builtin aliases with `cargo --list` (rust-lang/cargo#8542) - Check manifest for requiring nonexistent features (rust-lang/cargo#7950) - Clarify test name filter usage (rust-lang/cargo#8552) - Revert Cargo Book changes for default edition (rust-lang/cargo#8551) - Prepare for not defaulting to master branch for git deps (rust-lang/cargo#8522) - Include `+` for crates.io feature requirements in the Cargo Book section on features (rust-lang/cargo#8547) - Update termcolor and fwdansi versions (rust-lang/cargo#8540) - Cargo book nitpick in Manifest section (rust-lang/cargo#8543)
The Manifest section states on the example that the
default edition is 2018, but the lines of text above
state that the default is
2015which is not correct.Closes #8541