Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable RUSTC_BOOTSTRAP in build.rs #8667

Closed
wants to merge 1 commit into from

Conversation

notriddle
Copy link
Contributor

Closes #7088

@rust-highfive
Copy link

r? @ehuss

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 31, 2020
@notriddle notriddle closed this Aug 31, 2020
@notriddle
Copy link
Contributor Author

Never mind. Sorry for the noise. I didn't realize there was already a commit for this made by a Cargo team member.

@notriddle notriddle deleted the disable-bootstrap branch August 31, 2020 19:56
@RalfJung
Copy link
Member

RalfJung commented Oct 4, 2020

There's such a commit but it does not seem to be in any PR or branch?

@RalfJung
Copy link
Member

RalfJung commented Oct 4, 2020

Cc @jyn514

@jyn514
Copy link
Member

jyn514 commented Oct 4, 2020

I am not a cargo team member and I am not comfortable making a change like this. Feel free to reuse my code, but I won't be making a PR with it.

See https://zulip-archive.rust-lang.org/233931tcompilermajorchanges/42684RequireuserstoconfirmtheyknowRUSTCcompilerteam350.html#208403654 for more discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forbid setting RUSTC_BOOTSTRAP from a build script
5 participants