Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dylib+rlib with LTO. #8754

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Fix dylib+rlib with LTO. #8754

merged 1 commit into from
Oct 5, 2020

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 5, 2020

A mixed dylib+rlib crate with LTO was using the wrong settings. It was using OnlyObject, but the rlib needs bitcode when linked with other things.

Fixes #8673

@rust-highfive
Copy link

r? @Eh2406

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2020
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 5, 2020

📌 Commit 90e286d has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2020
@bors
Copy link
Contributor

bors commented Oct 5, 2020

⌛ Testing commit 90e286d with merge f5e5e0e...

@bors
Copy link
Contributor

bors commented Oct 5, 2020

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing f5e5e0e to master...

@bors bors merged commit f5e5e0e into rust-lang:master Oct 5, 2020
@bors bors mentioned this pull request Oct 5, 2020
Merged
@ehuss ehuss mentioned this pull request Oct 7, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 7, 2020
@bors
Auto merge of rust-lang#77637 - ehuss:update-cargo, r=ehuss
5296ac6 
Update cargo

3 commits in 75615f8e69f748d7ef0df7bc0b064a9b1f5c78b2..9d1a4863abd9237dbf9d1b74c78632b6a205f6bb
2020-09-29 18:42:19 +0000 to 2020-10-05 18:29:52 +0000
- Add LTO to the metadata filename hash. (rust-lang/cargo#8755)
- Fix dylib+rlib with LTO. (rust-lang/cargo#8754)
- Homepage doc cargo metadata (rust-lang/cargo#8744)
@krtab
Copy link
Contributor

krtab commented Nov 23, 2020

Hello @ehuss !
Thanks for the quick fix!
Shouldn't this patch be backported to stable given that the issues it is fixing is quite critical? Note that I consider the issue to be critical because even if we are few affected users, this issues will cause our crates not to build, when they previously used to.

@ehuss
Copy link
Contributor Author

ehuss commented Nov 23, 2020

Stable patch releases are decided by the release team, you may want to discuss with them (they can be reached on the t-release stream on Zulip). This has been broken since at least August, and only one user mentioned it, so it wasn't a terribly high priority at the time. I'd be fine with backporting to 1.48 if the release team is planning a patch release for other reasons, but I suspect this alone probably won't justify a new release.

@ehuss ehuss added this to the 1.49.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Eh2406 Eh2406

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.

lto = true causes build failure on macos
6 participants
@ehuss @rust-highfive @alexcrichton @bors @krtab @Eh2406