Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor typo in features.md #8851

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Minor typo in features.md #8851

merged 1 commit into from
Nov 12, 2020

Conversation

lfrancke
Copy link
Contributor

Just a very minor typo

(that said: these docs don't actually explain what a Feature group is before using the term, but that's for another issue)

Just a very minor typo

(that said: these docs don't actually explain what a Feature group is before using the term, but that's for another issue)
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2020
@ehuss
Copy link
Contributor

ehuss commented Nov 12, 2020

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Nov 12, 2020

📌 Commit f3519d7 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2020
@bors
Copy link
Contributor

bors commented Nov 12, 2020

⌛ Testing commit f3519d7 with merge 770f403...

@bors
Copy link
Contributor

bors commented Nov 12, 2020

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 770f403 to master...

@bors bors merged commit 770f403 into rust-lang:master Nov 12, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 13, 2020
Update cargo

Fixing an important publish bug.

2 commits in 8662ab427a8d6ad8047811cc4d78dbd20dd07699..2af662e22177a839763ac8fb70d245a680b15214
2020-11-12 03:47:53 +0000 to 2020-11-12 19:04:56 +0000
- Fix publishing with optional dependencies. (rust-lang/cargo#8853)
- Minor typo in features.md (rust-lang/cargo#8851)
@ehuss ehuss added this to the 1.50.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants