Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shrink the progress bar, to give more space after it. #8892

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Shrink the progress bar, to give more space after it. #8892

merged 1 commit into from
Nov 24, 2020

Commits on Nov 24, 2020

  1. Shrink the progress bar, to give more space after it. 

    Because:
- A big progress bar isn't necessary. Making it smaller loses some
  precision, but a big bar isn't that precise in the first place. If you
  precision you can look at the percentage or ratio figure after the
  progress bar anyway.
- A big bar sometimes obscures important info. For the "Building" step
  the crate names after the progress bar are important -- they make it
  clear how much parallelism is in the build. If you don't see that
  you're getting a much worse understanding of the build process.

On an 80-char wide terminal, the change looks like this. Before:
```
    Building [========>                                               ] 18/105
```
After:
```
    Building [=======================>  ] 97/105: goblin, pdb, symbolic-dem...
```

On a 100-char wide terminal, it looks like this. Before:
```
    Building [============================>                           ] 56/105: cpp_demangle(bu...
```
After:
```
    Building [============>             ] 56/105: byteorder, proc-macro2, pest, gimli, cpp_dema...
```
    @nnethercote
    nnethercote committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    7e780a9 View commit details
    Browse the repository at this point in the history