Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated display message of cargo metadata --help #9010

Closed
wants to merge 4 commits into from
Closed

Updated display message of cargo metadata --help #9010

wants to merge 4 commits into from

Conversation

bishtpawan
Copy link
Contributor

@bishtpawan bishtpawan commented Dec 22, 2020 •
edited
Loading

Resolved Issue #8928

@rust-highfive
Copy link

r? @alexcrichton

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 22, 2020
@bishtpawan bishtpawan changed the title Updated display message for cargo metadata Updated mdman.md for cargo metadata Dec 22, 2020
@bishtpawan bishtpawan changed the title Updated mdman.md for cargo metadata Updated display message of cargo metadata --help Dec 22, 2020
ehuss
ehuss reviewed Dec 23, 2020
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks like you were maybe trying to update the man pages? There is some documentation here on how they work. The file that needs to be updated is https://github.com/rust-lang/cargo/blob/master/src/doc/man/includes/options-display.md, and then you can run the build-man.sh script.

crates/mdman/doc/out/mdman.md
@@ -54,8 +54,8 @@ man page:

<dl>

<dt><code>-t</code> <em>type</em></dt>
<dd>Specifies the output type. The following output types are supported:</p>
<dt class="option-term" id="option-mdman--t"><a class="option-anchor" href="#option-mdman--t"></a><code>-t</code> <em>type</em></dt>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem to be some unrelated changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I thought we need to update the man page if we are updating any details. That's why this file got updated.
No worries I'll remove these changes.

Thanks for your response.

@ehuss ehuss added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2021
@ehuss ehuss assigned ehuss and unassigned alexcrichton Jan 6, 2021
@bishtpawan
Copy link
Contributor Author

Closing this PR. As I've raised a new one with the only required change. #9050

@bishtpawan bishtpawan closed this Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss left review comments

Assignees

@ehuss ehuss

Labels
S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bishtpawan @rust-highfive @ehuss @alexcrichton