Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

another round of clippy lint fixes #9051

Merged
merged 3 commits into from
Jan 6, 2021
Merged

another round of clippy lint fixes #9051

merged 3 commits into from
Jan 6, 2021

Commits on Jan 6, 2021

  1. reduce nesting of if x { } else { if y {} else {} } expressions by co… 

    …ncerting to if x {} else if y {} else {} (clippy::collapsible_else_if)
    @matthiaskrgr
    matthiaskrgr committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    8e3f97f View commit details
    Browse the repository at this point in the history

  2. fix clippy::unnecessary_wraps. 

    Make functions that return Options but only ever return Ok() return the wrapped value directly and remove redundant matching
    @matthiaskrgr
    matthiaskrgr committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    d12a8ba View commit details
    Browse the repository at this point in the history

  3. Fix more clippy warnings; 

    clippy::comparison_to_empty
clippy::needless_question_mark
clippy::needless_borrow
clippy::match_like_matches_macro
clippy::vec_init_then_push
clippy::redundant_clone
clippy::nonminimal_bool
clippy::ptr_arg
    @matthiaskrgr
    matthiaskrgr committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    c4e5670 View commit details
    Browse the repository at this point in the history