Commits on Jan 14, 2021

1. Fix a bug in Cargo's cyclic dep graph detection …

   Cargo's cyclic dependency graph detection turns out to have had a bug
   for quite a long time as surfaced by rust-lang#9073. The bug in Cargo has to do
   with how dev-dependencies are handled. Cycles are "allowed" through
   dev-dependencies because the dev-dependency can depend on the original
   crate. Our cyclic graph detection, however, was too eagerly flagging a
   package as known to not have a cycle before we had processed everything
   about it.
   
   The fix here was basically to just simplify the graph traversal. Instead
   of traversing the raw `Resolve` this instead creates an alternate
   in-memory graph which has the actual edges we care about for cycle
   detection (e.g. every edge that wasn't induced via a dev-dependency).
   With this simplified graph we then apply the exact same algorithm, but
   this time it should be less buggy because we're not trying to do funky
   things about switching sets about what's visited halfway through a
   traversal.
   
   Closes rust-lang#9073

   

   alexcrichton committed Jan 14, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 4b4dc0a
   • Browse repository at this point

   Copy the full SHA

   4b4dc0a View commit details

   Browse the repository at this point in the history