Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Click to go to toml file #9683

Closed
wants to merge 1 commit into from

Conversation

gilescope
Copy link
Contributor

When we have lots of rust we have lots of crates; getting to the right cargo toml file can be tricky.
If the full path to the Cargo.toml is in the output then IDEs like vscode can just click through to go to the file in question.

This is a prelude to what I really want: I want to be able to click on an error and go to a specific line number.
At least this way we can quickly get to the specific file if not the exact line that a dependency was defined at.

@rust-highfive
Copy link

r? @alexcrichton

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2021
@gilescope
Copy link
Contributor Author

   Compiling foo v0.0.1 (/home/runner/work/cargo/cargo/target/debug/tmp/cit/t2053/foo/Cargo.toml)
    Finished dev [unoptimized + debuginfo] target(s) in 0.25s

Idk, I quite like that explicitness but maybe we should restrict it to just adding the Cargo.toml when errors are mentioned.

@est31
Copy link
Member

est31 commented Jul 27, 2021

See also #7548 and rust-lang/rls#1581 .

@gilescope
Copy link
Contributor Author

Thanks going to give the full monty a crack: #9752

@gilescope gilescope closed this Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants