-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packages can inherit fields from their root workspace #9684
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9d559b6
Add additional fields to Cargo.toml for workspaces
Muscraft 62ba1f1
Add tests for additional fields in Cargo.toml for workspaces
Muscraft 0e7696c
Delayed parsing of manifests into packages until after a root config …
Muscraft 36bce7f
- Added inheriting TomlProject fields
Muscraft 3327880
- Fixed one call to SourceConfigMap.load() after merging
Muscraft da03efb
Merge branch 'rust-lang:master' into dedup_workspace
Muscraft 43487e9
Fixed CI problem with rust fmt
Muscraft 12302ad
Added tests to ensure published manifests do not contain workspace = …
Muscraft c6d75f5
Merge branch 'master' into dedup_workspace
Muscraft e02f69d
Merge branch 'master' into dedup_workspace
Muscraft f60aabf
- Added cache for InheritableFields
Muscraft 452d02b
Merge branch 'master' into dedup_workspace
Muscraft a7d41d6
- Fixed test for inherit_workspace_fields
Muscraft 155932d
- Fixed test for inherit_workspace_fields
Muscraft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this structure may want to be defined in the toml parsing area, otherwise it's pretty back-and-forth where it's created here but all the guts of processing happen later with
TomlManifest::to_real_manifest
.Also, would it be possible for
TomlManifest
to itself be an "intermediate" manifest?