Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish lockfile version req from normal dep in resolver error message #9847

Merged
merged 5 commits into from
Oct 5, 2021

Commits on Sep 20, 2021

  1. Add Locked variant for OptVersionReq

    `OptVersionReq::Locked` stores the original version requirement and the
    acutal locked version. This makes error message describing more precise.
    weihanglo committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    d6fd499 View commit details
    Browse the repository at this point in the history
  2. Update synthetic locked version_req to real locked

    Previously we use exact semver version req to synthesize locked version
    req. Now we make those need a truly locked to be `OptVersionReq::Locked`.
    weihanglo committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    c6762ce View commit details
    Browse the repository at this point in the history
  3. Show original version_req for locked dependency

    When encounter resolver error with locked dependency, we now show
    original version req along with the exact locked version.
    weihanglo committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    d226234 View commit details
    Browse the repository at this point in the history
  4. Compare version fields' equalities directly

    Instead of creating another VersionReq, this can reduce some extra
    efforts on version matching logic. Though it also may introduces
    divergence from semver's matching logic. Accordingly, we borrow unit
    tests from semver crate and compare the matching results to prevent
    future breaks.
    weihanglo committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    4ecb543 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. Configuration menu
    Copy the full SHA
    725420e View commit details
    Browse the repository at this point in the history