Allow cargo update --precise with metadata.
#9945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Eh2406 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ Sounds reasonable to me! |
|
📌 Commit 8fe3bde has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
ehuss
added a commit
to ehuss/rust
that referenced
this pull request
Sep 30, 2021
Update cargo 5 commits in 0121d66aa2ef5ffa9735f86c2b56f5fdc5a837a6..d56b42c549dbb7e7d0f712c51b39400260d114d4 2021-09-22 16:08:27 +0000 to 2021-09-27 13:44:18 +0000 - Allow `cargo update --precise` with metadata. (rust-lang/cargo#9945) - Support path_in_vcs as part of cargo_vcs_metadata (rust-lang/cargo#9866) - Doc about InstallTracker files and `install.root` (rust-lang/cargo#9948) - Add some clarity on the license/license-file warning. (rust-lang/cargo#9941) - Fix the problem that help cannot be displayed properly (rust-lang/cargo#9933)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo update --precisewould require that the version matches exactly, including build metadata. Usually the build metadata is ignored (like in dependency declarations), but in this circumstance it isn't. This can be awkward in some cases where it can be more convenient to type just the version number without the build metadata.This changes it so that if the metadata isn't provided, then it will be ignored when matching. Otherwise, it will be honored. This is slightly different from a version requirement like
=1.2.3+foowhich ignores the metadata completely.This also adds a slightly better error message if you don't type in valid syntax for a version number (previously it would just emit the
no matching packageerror).