Skip to content

Commit

Permalink
Merge pull request #769 from keith/ks/update-bitcode-todo
Browse files Browse the repository at this point in the history
  • Loading branch information
JohnTitor authored Jan 12, 2023
2 parents 203a57f + 03e5c7c commit 621ba2c
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2279,18 +2279,8 @@ impl Build {

cmd.args.push("-isysroot".into());
cmd.args.push(sdk_path);
// TODO: Remove this once Apple stops accepting apps built with Xcode 13
cmd.args.push("-fembed-bitcode".into());
/*
* TODO we probably ultimately want the -fembed-bitcode-marker flag
* but can't have it now because of an issue in LLVM:
* https://github.com/rust-lang/cc-rs/issues/301
* https://github.com/rust-lang/rust/pull/48896#comment-372192660
*/
/*
if self.get_opt_level()? == "0" {
cmd.args.push("-fembed-bitcode-marker".into());
}
*/

Ok(())
}
Expand Down

0 comments on commit 621ba2c

Please sign in to comment.