Fix msrv CI: Check for --all-features (#890)

* Fix msrv CI: Check for `--all-features` and macos To make sure that enabling `parallel` feature would not require bumping msrv. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * Use minimal-versions and fetch deps crates using stable Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * Fix fetching deps in msrv Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * Cache downlaoded crates since 1.46 is really slow in fetching Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * Skip msrv for macos-latest since newer xcode breaks 1.46 linking Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * CI: Disable fail-fast for msrv check Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * CI: Add feature to cache key of msrv Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * CI: Rm matrix features of msrv Since most of the time is spent on installing Rust, there's no point in parallelizing it. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> --------- Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
rust-lang · Nov 4, 2023 · 6c9be16 · 6c9be16
1 parent 59255ce
commit 6c9be16
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -114,16 +114,23 @@ jobs:
     name: MSRV
     runs-on: ${{ matrix.os }}
     strategy:
+      fail-fast: false
       matrix:
         os: [ubuntu-latest, windows-latest]
     steps:
     - uses: actions/checkout@v4
     - name: Install Rust
       run: |
         rustup toolchain install 1.46.0 --no-self-update --profile minimal
+        rustup toolchain install nightly --no-self-update --profile minimal
         rustup default 1.46.0
       shell: bash
+    - name: Create Cargo.lock with minimal version
+      run: cargo +nightly update -Zminimal-versions
+    - name: Cache downloaded crates since 1.46 is really slow in fetching
+      uses: Swatinem/rust-cache@v2
     - run: cargo check --lib
+    - run: cargo check --lib --all-features
 
   rustfmt:
     name: Rustfmt