Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*-alpine-linux-musl custom targets #1407

Closed
fossdd opened this issue Feb 20, 2025 · 6 comments · Fixed by #1413
Closed

*-alpine-linux-musl custom targets #1407

fossdd opened this issue Feb 20, 2025 · 6 comments · Fixed by #1413

Comments

@fossdd
Copy link

fossdd commented Feb 20, 2025

Hi, Alpine Linux contributor here.

I saw that you changed the target parsing and that the shipped target info doesn't include our own custom Alpine targets, which link dynamically than static.

It seems to me that this currently blocks the Rust upgrade to 1.85.0 since Rust 1.85 ships cc-1.2.x.

It would be nice to know what the best way forward would be here, if you have any idea. Thank you!

@q66
Copy link

q66 commented Feb 20, 2025

same with *-chimera-linux-musl targets, and i've arleady run into this elsewhere, like tree-sitter cli tool breaking its test command due to cc-rs raising an error at runtime (it never did so before)

i'm currently bumping up to 1.85 and i decided to add patches to the generated list in the vendored crate, but i feel like this is going to bite me in a lot of places starting very soon

@CutestNekoAqua
Copy link

I suggest proper dynamic parsing than static lists.

@ChrisDenton
Copy link
Member

Similar to #1405, I believe this is a dup of #1317

@awilfox
Copy link

awilfox commented Feb 21, 2025

it does seem related to #1317, yes. Chiming in as the maintainer of the *-foxkit-linux-musl triplet (which is used by Adélie Linux and in addition to dynamically linking musl also defines MMX as available on i586).

@fossdd
Copy link
Author

fossdd commented Feb 22, 2025

Similar to #1405, I believe this is a dup of #1317

Yeah, only that the error message (https://github.com/rust-lang/cc-rs/blob/main/src/target.rs#L75) led me to believe that there was a solution for custom targets, which apparently is not the case.

@NobodyXu
Copy link
Collaborator

We can parse the target and replace -alpine- and other os with -unknown-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants