Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid static list of LLVM triples #1431

Open
madsmtm opened this issue Mar 13, 2025 · 0 comments
Open

Avoid static list of LLVM triples #1431

madsmtm opened this issue Mar 13, 2025 · 0 comments
Assignees
@madsmtm
Labels
bug

Comments

@madsmtm
Copy link
Collaborator

madsmtm commented Mar 13, 2025

Continue the work in #1413, and avoid the pre-generated list of Clang/LLVM triples in favour of constructing it from the target information.

I'd like to make sure that this list matches what rustc, so I'm filing PRs to make their use of LLVM triples simpler:

Alternatively, maybe use rustc --print llvm-tuple if that becomes viable.
@madsmtm madsmtm added the bug label Mar 13, 2025
@madsmtm madsmtm self-assigned this Mar 13, 2025
This was referenced Mar 13, 2025
Merged
Open
Merged
Open
Open
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 13, 2025
@matthiaskrgr
Rollup merge of rust-lang#138427 - madsmtm:vxworks-llvm-target, r=jie…
69b3ad1 
…youxu

Fix RISC-V VxWorks LLVM target triples

The targets `riscv32-wrs-vxworks` and `riscv64-wrs-vxworks` uses the plain `$ARCH` LLVM triple, which LLVM normalizes to `$ARCH-unknown-unknown`, we should use `$ARCH-unknown-linux-gnu$ABI` which is consistent with the the other VxWorks targets.

Motivation: To make it easier to verify that [`cc-rs`' conversion from `rustc` to Clang/LLVM triples](rust-lang/cc-rs#1431) is correct.

Alternative: Pass `$ARCH-unknown-none` in the other VxWorks LLVM triples, I don't know anything about VxWorks, so am unsure which is the most correct option.

CC target maintainer `@biabbas.`
r? jieyouxu
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 13, 2025
@rust-timer
Unrolled build for rust-lang#138427
abc277c 
Rollup merge of rust-lang#138427 - madsmtm:vxworks-llvm-target, r=jieyouxu

Fix RISC-V VxWorks LLVM target triples

The targets `riscv32-wrs-vxworks` and `riscv64-wrs-vxworks` uses the plain `$ARCH` LLVM triple, which LLVM normalizes to `$ARCH-unknown-unknown`, we should use `$ARCH-unknown-linux-gnu$ABI` which is consistent with the the other VxWorks targets.

Motivation: To make it easier to verify that [`cc-rs`' conversion from `rustc` to Clang/LLVM triples](rust-lang/cc-rs#1431) is correct.

Alternative: Pass `$ARCH-unknown-none` in the other VxWorks LLVM triples, I don't know anything about VxWorks, so am unsure which is the most correct option.

CC target maintainer `@biabbas.`
r? jieyouxu
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Mar 14, 2025
@matthiaskrgr
Rollup merge of #138427 - madsmtm:vxworks-llvm-target, r=jieyouxu
3812966 
Fix RISC-V VxWorks LLVM target triples

The targets `riscv32-wrs-vxworks` and `riscv64-wrs-vxworks` uses the plain `$ARCH` LLVM triple, which LLVM normalizes to `$ARCH-unknown-unknown`, we should use `$ARCH-unknown-linux-gnu$ABI` which is consistent with the the other VxWorks targets.

Motivation: To make it easier to verify that [`cc-rs`' conversion from `rustc` to Clang/LLVM triples](rust-lang/cc-rs#1431) is correct.

Alternative: Pass `$ARCH-unknown-none` in the other VxWorks LLVM triples, I don't know anything about VxWorks, so am unsure which is the most correct option.

CC target maintainer `@biabbas.`
r? jieyouxu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madsmtm madsmtm

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@madsmtm