Drop support for Visual Studio 12 (2013) #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems reasonable to drop vs 12, but I will wait for others' review in case they are against this change. |
thomcc
reviewed
May 1, 2024
|
As per zulip discussion, we decided to wait until msrv is bumped to 1.66 since the current msrv of cc still supports vs 12, merging it now might break some users. Once msrv is bumped to 1.66, we will merge this. |
|
Discussion is in t-libs/crates, request review for cc-rs |
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
NobodyXu
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio 2013 went out of support on Apr 9, 2024: https://learn.microsoft.com/en-us/lifecycle/products/visual-studio-2013
Additionally, the Rust Compiler has required Visual Studio 2017 since 1.66: rust-lang/rust@9b3db34