support "vxworks" and "nto" OSes on get_base_archiver_variant
#1456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
|
Thanks for the review, I will address your notes once I get some free time (probably around the weekend). |
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
extend-ar-finding
branch
11 times, most recently
from
b1e4bd0 to
59c3044
Compare
|
Any updates on this? It's blocking one of the FIXMEs on rustc bootstrap. |
madsmtm
approved these changes
May 13, 2025
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
extend-ar-finding
branch
from
59c3044 to
e3b04dc
Compare
|
Should be ready now. Any idea when this can be released with a new cc-rs version? |
NobodyXu
approved these changes
May 14, 2025
It would be super nice if we can land this before the release happens. 😄 |
|
Sorry I forgot to click on the merge button yesterday, somehow my brain thinks I've already done that 😅 |
Merged
fmease
added a commit
to fmease/rust
that referenced
this pull request
May 18, 2025
…larsan68 replace `cc_detect::cc2ar` with `cc::try_get_archiver` ~~Awaiting new release of [cc](https://crates.io/crates/cc) version with rust-lang/cc-rs#1456 to bump the version.~~ ~~Blocked by rust-lang/cc-rs#1456 Kind a self-explanatory.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 18, 2025
replace `cc_detect::cc2ar` with `cc::try_get_archiver` ~~Awaiting new release of [cc](https://crates.io/crates/cc) version with rust-lang/cc-rs#1456 to bump the version.~~ ~~Blocked by rust-lang/cc-rs#1456 Kind a self-explanatory. try-job: arm-android
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2025
replace `cc_detect::cc2ar` with `cc::try_get_archiver` ~~Awaiting new release of [cc](https://crates.io/crates/cc) version with rust-lang/cc-rs#1456 to bump the version.~~ ~~Blocked by rust-lang/cc-rs#1456 Kind a self-explanatory. try-job: arm-android
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2025
replace `cc_detect::cc2ar` with `cc::try_get_archiver` ~~Awaiting new release of [cc](https://crates.io/crates/cc) version with rust-lang/cc-rs#1456 to bump the version.~~ ~~Blocked by rust-lang/cc-rs#1456 Kind a self-explanatory. try-job: arm-android
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2025
replace `cc_detect::cc2ar` with `cc::try_get_archiver` ~~Awaiting new release of [cc](https://crates.io/crates/cc) version with rust-lang/cc-rs#1456 to bump the version.~~ ~~Blocked by rust-lang/cc-rs#1456 Kind a self-explanatory. try-job: arm-android
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2025
…rsan68 replace `cc_detect::cc2ar` with `cc::try_get_archiver` ~~Awaiting new release of [cc](https://crates.io/crates/cc) version with rust-lang/cc-rs#1456 to bump the version.~~ ~~Blocked by rust-lang/cc-rs#1456 Kind a self-explanatory. try-job: arm-android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the archiver detection logic to support the "vxworks" and "nto" operating systems. This change will allow us to remove this custom bootstrap logic and rely entirely on the
cccrate as it already supports all other AR finding conditions handled by bootstrap. You can try this patch to test this.The original PRs that introduced these conditions in the bootstrap are: