Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to double-float ABI on RISC-V Linux #460

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

msizanoen1
Copy link
Contributor

@msizanoen1 msizanoen1 commented Dec 1, 2019

@msizanoen1
Copy link
Contributor Author

Also RISC-V ELF psABI documentation says that the default ABI is always double-float: https://github.com/riscv/riscv-elf-psabi-doc/blob/master/riscv-elf.md#default-abis
Maybe we can only use soft-float ABI for *-none-* target?

@msizanoen1
Copy link
Contributor Author

msizanoen1 commented Dec 2, 2019

Also there is riscv64gc-unknown-none-elf target and riscv32imafdc-unknown-none-elf target that supports hard float. Should we default to double-float ABI for these target in rustc?

@alexcrichton alexcrichton merged commit 15fe24a into rust-lang:master Dec 2, 2019
@alexcrichton
Copy link
Member

I'm not personally too familiar with the various naming conventions around the riscv targets, but I'm happy to merge PRs to incrementally improve support!

@msizanoen1 msizanoen1 deleted the riscv-double-float branch December 3, 2019 05:15
@msizanoen1
Copy link
Contributor Author

Now a new cc version should be released to crates.io?

@alexcrichton
Copy link
Member

Sure thing, done now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants