Add the host architecture Windows 10 SDK bin directory to the PATH, not the target #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Would it be possible to add a test for this on CI? |
…ot the target. Fixes failures during cross-compilation when the host cannot execute the target architecture Windows 10 SDK tools. Also adds the target tools bin to the PATH before the host_dylib_path is added. This ensures that if a target-specific version of a tool is available, it is preferred.
|
I added a CI task targeting aarch64 -- hopefully did that right. The tests already include running I also manually ran the aarch64 tests locally. |
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failures during cross-compilation when the host cannot execute the target architecture Windows 10 SDK tools.