Match abi and march settings for riscv on linux #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linux distros have agreed on using lp64d on 64bit and ilp32d on 32bit for ABI, we also need to match the march values which can support these ABIs and therefore use rv64gc and rv32gc for march Fixes errors when compiling libstd-rs e.g. warning: Assembler messages: warning: Error: -march=rv64: first ISA extension must be `e', `i' or `g' warning: cc1plus: error: '-march=rv64': first ISA subset must be 'e', 'i' or 'g'
Signed-off-by: Khem Raj <raj.khem@gmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linux distros have agreed on using lp64d on 64bit and
ilp32d on 32bit for ABI, we also need to match the march
values which can support these ABIs and therefore use rv64gc
and rv32gc for march
Fixes errors when compiling libstd-rs e.g.
warning: Assembler messages:
warning: Error: -march=rv64: first ISA extension must be
e',i' or `g'warning: cc1plus: error: '-march=rv64': first ISA subset must be 'e', 'i' or 'g'