-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Loongarch64 support #637
Conversation
Thanks! Is there an upstream rust target specification for this target? |
Yes, the definition of this target is based on the rust target specification. |
Hm I don't see the target here? https://github.com/rust-lang/rust/tree/master/compiler/rustc_target/src/spec |
Sorry, we are still testing and developing rust-lang/rust locally. After the testing is completed, we will submit it to the upstream community. |
Ah ok sounds good, would you be ok if I hold off on merging this until your target is closer to being merged into rust-lang/rust? |
Of course. |
If cc-rs can be incorporated into the community, it will be friendly to users of the new architecture, because they do not need to manually adapt it locally every time they use it. |
Yes that makes sense @zhaixiaojuan, but I prefer to have targets landed in rust-lang/rust before they're added here. |
@alexcrichton The loongarch64-unknown-linux-gnu was added as a tier 3 target, could you review this patch again please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Loongarch is a new RISC architecture.
Loongarch doc: https://github.com/loongson-community/LoongArch-Documentation/