Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Loongarch64 support #637

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Add Loongarch64 support #637

merged 1 commit into from
Apr 24, 2023

Conversation

zhaixiaojuan
Copy link
Contributor

Loongarch is a new RISC architecture.
Loongarch doc: https://github.com/loongson-community/LoongArch-Documentation/

@alexcrichton
Copy link
Member

Thanks! Is there an upstream rust target specification for this target?

@zhaixiaojuan
Copy link
Contributor Author

Yes, the definition of this target is based on the rust target specification.
And regarding rust's support for loongarch64 architecture, we are under development.

@alexcrichton
Copy link
Member

@zhaixiaojuan
Copy link
Contributor Author

Sorry, we are still testing and developing rust-lang/rust locally. After the testing is completed, we will submit it to the upstream community.

@alexcrichton
Copy link
Member

Ah ok sounds good, would you be ok if I hold off on merging this until your target is closer to being merged into rust-lang/rust?

@zhaixiaojuan
Copy link
Contributor Author

zhaixiaojuan commented Nov 25, 2021

Of course.
However, the integration of rust-lang/rust and its dependent library libc into the community may be a long-term work.

@zhaixiaojuan
Copy link
Contributor Author

If cc-rs can be incorporated into the community, it will be friendly to users of the new architecture, because they do not need to manually adapt it locally every time they use it.

@alexcrichton
Copy link
Member

Yes that makes sense @zhaixiaojuan, but I prefer to have targets landed in rust-lang/rust before they're added here.

@heiher
Copy link

heiher commented Apr 24, 2023

@alexcrichton The loongarch64-unknown-linux-gnu was added as a tier 3 target, could you review this patch again please?

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JohnTitor JohnTitor merged commit 52a7cb7 into rust-lang:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants