Fix PrintThread: Read stderr as bytes instead of str
#842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to accept non-utf-8 characters. Fixed #841 Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
thomcc
approved these changes
Aug 2, 2023
TBF, I also missed the original comment and uses |
|
TBH it was a big release, so it's not that surprising something was missed. That said, this is quite bad, so I'll try to put out another one with this (and anything else that comes up by then) in it tomorrow morning or so (it is late for me). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to accept non-utf-8 characters.
Fixed #841