fix: Add apple tvos support #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomcc
reviewed
Oct 3, 2023
| @@ -507,33 +507,3 @@ fn gnu_apple_darwin() { | |||
| cmd.must_not_have("-isysroot"); | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
These tests didn't require GCC, just check that the target-specific stuff works. They shouldn't be deleted.
There should also be a test that clang works and has everything set appropriately.
thomcc
requested changes
Oct 4, 2023
lcruz99
force-pushed
the
add_apple_tvos_support
branch
from
ad0a29d to
efda48f
Compare
lcruz99
force-pushed
the
add_apple_tvos_support
branch
from
fe860cb to
d383b31
Compare
NobodyXu
requested changes
Oct 31, 2023
lcruz99
force-pushed
the
add_apple_tvos_support
branch
5 times, most recently
from
3dc7e6b to
73a730d
Compare
lcruz99
force-pushed
the
add_apple_tvos_support
branch
from
73a730d to
f8eaa95
Compare
NobodyXu
requested changes
Nov 9, 2023
lcruz99
force-pushed
the
add_apple_tvos_support
branch
from
f8eaa95 to
a92bedf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows using cc-rs lib to target tier 3 *-apple builds:
As clang should be used with this target, I've removed tests added on #704 that require gcc.Restored tests.