Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix msrv CI: Check for --all-features #890

Merged
merged 8 commits into from
Nov 4, 2023
Merged

Fix msrv CI: Check for --all-features #890

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ba2cd0f
Fix msrv CI: Check for `--all-features` and macos
NobodyXu Oct 27, 2023
59a590f
Use minimal-versions and fetch deps crates using stable
NobodyXu Oct 27, 2023
e00afc8
Fix fetching deps in msrv
NobodyXu Oct 27, 2023
54630e0
Cache downlaoded crates since 1.46 is really slow in fetching
NobodyXu Oct 27, 2023
7a35901
Skip msrv for macos-latest since newer xcode breaks 1.46 linking
NobodyXu Oct 27, 2023
e1a3f58
CI: Disable fail-fast for msrv check
NobodyXu Oct 27, 2023
ab2db8e
CI: Add feature to cache key of msrv
NobodyXu Oct 27, 2023
cac7893
CI: Rm matrix features of msrv
NobodyXu Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,16 +114,23 @@ jobs:
name: MSRV
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest]
steps:
- uses: actions/checkout@v3
- name: Install Rust
run: |
rustup toolchain install 1.46.0 --no-self-update --profile minimal
rustup toolchain install nightly --no-self-update --profile minimal
rustup default 1.46.0
shell: bash
- name: Create Cargo.lock with minimal version
run: cargo +nightly update -Zminimal-versions
- name: Cache downloaded crates since 1.46 is really slow in fetching
uses: Swatinem/rust-cache@v2
- run: cargo check --lib
- run: cargo check --lib --all-features

rustfmt:
name: Rustfmt
Expand Down