Add support for ARM64EC when building with MSVC #910
Conversation
dpaoliello
force-pushed
the
arm64ec
branch
2 times, most recently
from
5692c65 to
52a3f46
Compare
|
@ChrisDenton would you mind having a look at this PR? It's blocking adding ARM64EC as a new target, and also provides some cleanups to avoid splitting the target triple over-and-over again within |
|
For sure, I'm still catching up on review but I'll prioritize this. |
ChrisDenton
left a comment
ChrisDenton
left a comment
There was a problem hiding this comment.
Looks good to me. I have one observation but nothing that should block merging this.
I do think using TargetArch is a clear improvement even without the other changes in this PR.
| target: TargetArch<'_>, | ||
| instance_path: &Path, | ||
| ) -> Option<(PathBuf, PathBuf, PathBuf, PathBuf, PathBuf)> { | ||
| ) -> Option<(PathBuf, PathBuf, PathBuf, PathBuf, Option<PathBuf>, PathBuf)> { |
There was a problem hiding this comment.
I think this return type is getting increasingly out of hand and should probably be a proper struct or otherwise rearchitectured. However, vs15plus_vc_paths is only called from one place and that immediately deconstructs it into named variables so I'm not minded to block this PR on that.
2 participants
-arm64ECflag to cl.exe and/machine:arm64ecto lib.exe: https://learn.microsoft.com/en-us/windows/arm/arm64ec-build#developer-command-promptarm64ecas a target arch by using theaarch64paths.arm64ecthe lib path must ALSO include thearm64ecVC libs BEFORE theaarch64libs.TargetArchwrapper type to avoid splitting the target string multiple times or callingcontainswhen we could be using string comparison.